Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boardsource technik #13111

Merged
merged 7 commits into from
Jul 20, 2021
Merged

Boardsource technik #13111

merged 7 commits into from
Jul 20, 2021

Conversation

daysgobye
Copy link
Contributor

@daysgobye daysgobye commented Jun 4, 2021 •
edited
Loading

Description

Added staggered version of technik keyboard the technik-s to the Boardsource folder.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 4, 2021
@daysgobye
Copy link
Contributor Author

This keyboard is 1 of 3 in a GB So I know for the next two is it better to keep it one keyboard per pr?

@daysgobye daysgobye mentioned this pull request Jun 4, 2021
Merged
6 tasks
@daysgobye
Copy link
Contributor Author

are more changes needed?

@drashna drashna requested a review from a team July 6, 2021 23:53
fauxpark
fauxpark requested changes Jul 7, 2021
View reviewed changes
keyboards/boardsource/technik_s/readme.md Outdated Show resolved Hide resolved
keyboards/boardsource/technik_s/readme.md Outdated Show resolved Hide resolved
keyboards/boardsource/technik_s/readme.md Outdated Show resolved Hide resolved
keyboards/boardsource/technik_s/readme.md Outdated Show resolved Hide resolved
keyboards/boardsource/technik_s/rules.mk Outdated Show resolved Hide resolved
@daysgobye daysgobye requested a review from fauxpark July 19, 2021 20:29
@fauxpark fauxpark requested a review from a team July 19, 2021 23:15
@drashna
Copy link
Member

drashna commented Jul 20, 2021

Thanks!

@drashna drashna merged commit 6ab0593 into qmk:master Jul 20, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@daysgobye @fauxpark @nhongooi
[Keyboard] Boardsource technik (qmk#13111)
f939fd9 
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daysgobye @drashna @fauxpark