Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weak refs on reading rows/cols. #13062

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jun 1, 2021

Description

Allow for keyboards to override implementations full-port reads without messing with the rest of the scanning logic, and without requiring a full custom matrix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team June 1, 2021 03:41
@github-actions github-actions bot added the core label Jun 1, 2021
@drashna drashna requested a review from a team June 1, 2021 03:48
@tzarc tzarc marked this pull request as ready for review June 1, 2021 05:10
@tzarc tzarc merged commit e5d3e5a into qmk:develop Jun 1, 2021
@mtei
Copy link
Contributor

mtei commented Jun 1, 2021

I am not opposed to this change.

However, there is something that I feel is insufficient in this change.

If a keyboard author implements matrix_init_pins() and matrix_read_cols_on_row() in his own way, does he need the configuration macros MATRIX_ROW_PINS and MATRIX_COL_PINS? And does he need pin_t row_pins[MATRIX_ROWS] and pin_t col_pins[MATRIX_COLS]?

It would be nice to have some explanation of these points in the documentation.

@tzarc
Copy link
Member Author

tzarc commented Jun 1, 2021

Fair enough. Will try and add something to #13064.

@tzarc tzarc deleted the overridable-col-row-reads branch June 1, 2021 10:51
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants