Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add anomalykb a65i #12967

Merged
merged 24 commits into from
Jul 20, 2021
Merged

add anomalykb a65i #12967

merged 24 commits into from
Jul 20, 2021

Conversation

lfgberg
Copy link

@lfgberg lfgberg commented May 20, 2021

Description

Added support for the anomalykb a65i pcb

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 20, 2021
drashna
drashna requested changes May 22, 2021
View reviewed changes
keyboards/anomalykb/a65i/a65i.c Show resolved Hide resolved
keyboards/anomalykb/a65i/config.h Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/config.h Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/keymaps/ansi_splitbs/config.h Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/keymaps/iso/config.h Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/keymaps/iso_splitbs/config.h Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/keymaps/via/config.h Show resolved Hide resolved
keyboards/anomalykb/a65i/rules.mk Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/rules.mk Outdated Show resolved Hide resolved
@lfgberg lfgberg requested a review from drashna May 23, 2021 01:49
lfgberg and others added 2 commits May 27, 2021 07:45
@lfgberg @drashna
Update keyboards/anomalykb/a65i/config.h
0f791cb 
removed deprecated PREVENT_STUCK_MODIFIERS

Co-authored-by: Drashna Jaelre <[email protected]>
@lfgberg
Delete config.h
e1ebfc6
@lfgberg lfgberg requested a review from drashna May 31, 2021 16:12
@drashna drashna requested a review from a team July 16, 2021 01:26
fauxpark
fauxpark requested changes Jul 16, 2021
View reviewed changes
keyboards/anomalykb/a65i/info.json Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/info.json Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/info.json Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/info.json Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/keymaps/ansi_splitbs/keymap.c Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/readme.md Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/readme.md Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/rules.mk Show resolved Hide resolved
keyboards/anomalykb/a65i/rules.mk Outdated Show resolved Hide resolved
keyboards/anomalykb/a65i/keymaps/via/keymap.c Outdated Show resolved Hide resolved
lfgberg and others added 10 commits July 16, 2021 19:26
@lfgberg @fauxpark
Update keyboards/anomalykb/a65i/info.json
a048291 
Co-authored-by: Ryan <[email protected]>
@lfgberg @fauxpark
Update keyboards/anomalykb/a65i/info.json
d18ac54 
Co-authored-by: Ryan <[email protected]>
@lfgberg @fauxpark
Update keyboards/anomalykb/a65i/info.json
b0c6e08 
Co-authored-by: Ryan <[email protected]>
@lfgberg @fauxpark
Update keyboards/anomalykb/a65i/info.json
5fc923a 
Co-authored-by: Ryan <[email protected]>
@lfgberg @fauxpark
Update keyboards/anomalykb/a65i/keymaps/ansi_splitbs/keymap.c
caf361d 
Co-authored-by: Ryan <[email protected]>
@lfgberg @fauxpark
Update keyboards/anomalykb/a65i/readme.md
a24a450 
Co-authored-by: Ryan <[email protected]>
@lfgberg @fauxpark
Update keyboards/anomalykb/a65i/readme.md
19c1f1f 
Co-authored-by: Ryan <[email protected]>
@lfgberg @fauxpark
Update keyboards/anomalykb/a65i/rules.mk
c253853 
Co-authored-by: Ryan <[email protected]>
@lfgberg @fauxpark
Update keyboards/anomalykb/a65i/rules.mk
70d614a 
Co-authored-by: Ryan <[email protected]>
@lfgberg @fauxpark
Update keyboards/anomalykb/a65i/keymaps/via/keymap.c
d85ff8b 
Co-authored-by: Ryan <[email protected]>
@lfgberg lfgberg requested a review from fauxpark July 16, 2021 23:28
fauxpark
fauxpark requested changes Jul 17, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some outstanding suggestions.

@lfgberg
Copy link
Author

lfgberg commented Jul 18, 2021

Still some outstanding suggestions.

My bad, thought I'd gotten them all, thanks!

@lfgberg lfgberg requested a review from fauxpark July 18, 2021 13:37
@fauxpark fauxpark requested a review from a team July 18, 2021 13:56
@drashna
Copy link
Member

drashna commented Jul 20, 2021

Thanks!

@drashna drashna merged commit 9d52349 into qmk:master Jul 20, 2021
@lfgberg lfgberg mentioned this pull request Jul 22, 2021
Merged
6 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@lfgberg @drashna
@fauxpark @nhongooi
[Keyboard] add anomalykb a65i (qmk#12967)
796e0f1 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfgberg @drashna @fauxpark