Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luggage rack #12959

Merged
merged 22 commits into from
Jul 20, 2021
Merged

luggage rack #12959

merged 22 commits into from
Jul 20, 2021

Conversation

AlisGraveNil
Copy link
Contributor

Description

This is a 13-key macropad. It's the 3-wide nav cluster between the alphanumerics and the numpad.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes May 22, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to rebase to fix the git submodules.

@AlisGraveNil AlisGraveNil force-pushed the Clawsome-Luggage-Rack branch from a5dbe7b to 9125317 Compare May 22, 2021 15:55
@AlisGraveNil
Copy link
Contributor Author

@drashna - I think the rebase worked

@AlisGraveNil AlisGraveNil changed the title Luggage Rack luggage rack May 22, 2021
drashna
drashna approved these changes May 22, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

LGTM.

@drashna drashna requested a review from a team May 22, 2021 17:07
@fauxpark
Copy link
Member

Also, missing a readme.

@AlisGraveNil
Copy link
Contributor Author

@fauxpark - I've uploaded the readme

@github-actions github-actions bot added CI cli qmk cli command core documentation keymap python translation via Adds via keymap and/or updates keyboard for via support labels Jun 16, 2021
@AlisGraveNil
Copy link
Contributor Author

@drashna How do I make this PR un-pull those thousands of files?

@github-actions github-actions bot removed python keymap cli qmk cli command CI documentation core via Adds via keymap and/or updates keyboard for via support translation labels Jul 11, 2021
@AlisGraveNil
Copy link
Contributor Author

@fauxpark okay - excess files removed, readme added

@drashna
Copy link
Member

drashna commented Jul 20, 2021

Thanks!

@drashna drashna merged commit 4f88080 into qmk:master Jul 20, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@AlisGraveNil @nhongooi
[Keyboard] luggage rack (qmk#12959)
9bc911d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlisGraveNil @fauxpark @drashna