-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keymap_extras
: Remove deprecated defines
#12949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
fauxpark
force-pushed
the
keymap-extras-remove-deprecated
branch
from
May 30, 2021 09:30
421d79c
to
03af82d
Compare
Bump |
Erovia
approved these changes
Jun 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Although we should probably at least ping the affected users.
I would but...that list is way too long. |
Yeah, I know, hence the approval and "probably". In any case, at some point we will need to rip the band-aid off, so might as well do it now. |
drashna
approved these changes
Jul 1, 2021
tzarc
approved these changes
Jul 5, 2021
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Jul 7, 2021
* qmk/develop: (23 commits) Use the new ST7565 driver on Ergodox Infinity (qmk#13165) Xelus Ninjin: rename LAYOUT_all to LAYOUT_tkl_ansi_tsangan; add info.json (qmk#13477) Kopibeng XT65: Layout Macro Refactor (qmk#13476) [Keyboard] Add poker87c and poker87d (qmk#12810) [Keyboard] Add new Elise, 65% Keyboard ANSI / ISO (qmk#12782) [Keyboard] Add bm65iso (qmk#13400) [Keyboard] Add keyboard reviung5 (qmk#13375) [Keyboard] Add kabedon98e (qmk#13314) [Keyboard] Set reasonable defaults for Corne keyboard (qmk#13440) /bin/bash to /usr/bin/env bash (qmk#13422) Update `MSG_PYTHON_MISSING` (qmk#13427) core: chibios: bootloader: use integer pointers as volatile (qmk#13450) Migrate SHIFT_ESC and RGB `fn_actions` to Grave Escape and RGB keycodes (qmk#13360) `keymap_extras`: Remove deprecated defines (qmk#12949) [Keyboard] fix encoder_update_user for nullbitsco/nibble (qmk#13451) Traveller cleanup (qmk#13441) LatinPadBLE: correct info.json data (qmk#13452) Jabberwocky: adjust key positioning in Configurator (qmk#13447) Molecule: Layout Macro Refactor (qmk#13453) [Docs] added list of MIDI keycodes (qmk#13159) ...
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
sroccaserra
added a commit
to sroccaserra/keyboard
that referenced
this pull request
Jan 7, 2022
Note, changes came from: - qmk/qmk_firmware#8591 - qmk/qmk_firmware#12697 - qmk/qmk_firmware#12949
sroccaserra
added a commit
to sroccaserra/keyboard
that referenced
this pull request
Jan 7, 2022
Note, changes came from: - qmk/qmk_firmware#8591 - qmk/qmk_firmware#12697 - qmk/qmk_firmware#12949
sroccaserra
added a commit
to sroccaserra/keyboard
that referenced
this pull request
Jan 13, 2022
Note, changes came from: - qmk/qmk_firmware#8591 - qmk/qmk_firmware#12697 - qmk/qmk_firmware#12949
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The time has come...
Types of Changes
Issues Fixed or Closed by This PR
Checklist