Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the Durgod Hades, Galaxy and Venus Keyboards #12893

Merged
merged 11 commits into from
Jul 20, 2021
Merged

Add support for the Durgod Hades, Galaxy and Venus Keyboards #12893

merged 11 commits into from
Jul 20, 2021

Conversation

J-Sully
Copy link

@J-Sully J-Sully commented May 14, 2021 •
edited
Loading

Description

This PR adds support for the Durgod DGK6X set of keyboards which include the Hades, Galaxy, and Venus keyboards.

Also includes VIA keymaps.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core documentation keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 14, 2021
@drashna drashna added the awaiting_pr Relies on another PR to be merged first label May 14, 2021
@tzarc tzarc requested a review from a team May 19, 2021 03:35
@J-Sully
Copy link
Author

J-Sully commented May 26, 2021

@drashna hello, I rebased my branch off develop, which now includes #12342 . Could you remove the awaiting_pr tag? Thank you for your time.

@drashna drashna removed the awaiting_pr Relies on another PR to be merged first label May 27, 2021
drashna
drashna requested changes May 27, 2021
View reviewed changes
keyboards/durgod/dgk6x/dgk6x.c Outdated Show resolved Hide resolved
keyboards/durgod/dgk6x/dgk6x.c Outdated Show resolved Hide resolved
keyboards/durgod/dgk6x/rules.mk Outdated Show resolved Hide resolved
keyboards/durgod/dgk6x/rules.mk Show resolved Hide resolved
keyboards/durgod/dgk6x/rules.mk Outdated Show resolved Hide resolved
@J-Sully
Copy link
Author

J-Sully commented Jun 3, 2021

Rebased off of develop

fauxpark
fauxpark requested changes Jun 3, 2021
View reviewed changes
keyboards/durgod/dgk6x/venus/info.json Outdated Show resolved Hide resolved
keyboards/durgod/dgk6x/hades/info.json Outdated Show resolved Hide resolved
@J-Sully J-Sully changed the title Add support for the Durgod Hades and Venus Keyboards Add support for the Durgod Hades, Galaxy and Venus Keyboards Jun 9, 2021
@drashna drashna requested a review from a team July 3, 2021 07:31
@drashna
Copy link
Member

drashna commented Jul 20, 2021

Thanks!

@drashna drashna merged commit 4188d22 into qmk:develop Jul 20, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@J-Sully @drashna
@dkjer @nhongooi
[Keyboard] Add Durgod Hades, Galaxy and Venus Keyboards (qmk#12893)
fa68da9 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Don Kjer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@dkjer dkjer dkjer left review comments

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@J-Sully @drashna @dkjer @fauxpark