Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB Matrix working for Sofle RGB #12861

Merged
merged 18 commits into from
Jun 7, 2021
Merged

Conversation

killmaster
Copy link

@killmaster killmaster commented May 11, 2021

Sofle RGB working with RGB Matrix and with both halves properly synced

Description

Added the g_led_config to the rev1.c file (based it off of Djinn's rev2 and crkbdr rev1).
Completed the config.h file on the killmaster keymap to work with the RGB Matrix.
Added more functionality to the encoders, so they can control the hue, saturation, value and speed of the matrix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/sofle/keymaps/killmaster/config.h Show resolved Hide resolved
keyboards/sofle/keymaps/killmaster/encoder.c Outdated Show resolved Hide resolved
keyboards/sofle/keymaps/killmaster/keymap.c Show resolved Hide resolved
keyboards/sofle/keymaps/killmaster/keymap.c Outdated Show resolved Hide resolved
keyboards/sofle/keymaps/killmaster/encoder.c Outdated Show resolved Hide resolved
keyboards/sofle/keymaps/killmaster/config.h Show resolved Hide resolved
keyboards/sofle/keymaps/killmaster/keymap.c Outdated Show resolved Hide resolved
keyboards/sofle/rev1/rev1.c Show resolved Hide resolved
keyboards/sofle/rev1/rev1.c Outdated Show resolved Hide resolved
keyboards/sofle/rev1/rev1.c Outdated Show resolved Hide resolved
Added license;
Using tap_code_delay;
Deleted encoder.c since it wasn't doing anything;
keyboards/sofle/keymaps/killmaster/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team May 16, 2021 00:06
keyboards/sofle/rev1/readme.md Outdated Show resolved Hide resolved
keyboards/sofle/keymaps/killmaster/rules.mk Outdated Show resolved Hide resolved
keyboards/sofle/keymaps/killmaster/keymap.c Outdated Show resolved Hide resolved
keyboards/sofle/keymaps/killmaster/keymap.c Outdated Show resolved Hide resolved
keyboards/sofle/keymaps/killmaster/keymap.c Outdated Show resolved Hide resolved
keyboards/sofle/keymaps/killmaster/keymap.c Outdated Show resolved Hide resolved
@drashna drashna merged commit 2e68897 into qmk:develop Jun 7, 2021
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants