Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sync_timer over serial_link (i.e. Ergodox Infinity). #12845

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Add support for sync_timer over serial_link (i.e. Ergodox Infinity). #12845

merged 1 commit into from
Jun 20, 2021

Conversation

firetech
Copy link
Contributor

@firetech firetech commented May 9, 2021 •
edited
Loading

Add ability to sync the sync_timer over the serial_link system used by Ergodox Infinity.

More or less just a port from split_common/transport.c and some tweaked #ifs in sync_timer.[ch].

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label May 9, 2021
@fauxpark fauxpark mentioned this pull request May 9, 2021
Merged
13 tasks
@drashna drashna requested review from fauxpark and a team May 10, 2021 22:42
@firetech
Copy link
Contributor Author

firetech commented May 11, 2021 •
edited
Loading

FYI: I'll (probably) see if I can switch Ergodox Infinity over to split_common this weekend. No guarantees, though. 😛

@fauxpark
Copy link
Member

All good, I was really just thinking out loud there tbh. I'm half expecting it to not be possible without an ugly hack or two.

@firetech
Copy link
Contributor Author

All good, I was really just thinking out loud there tbh. I'm half expecting it to not be possible without an ugly hack or two.

I'm still intrigued by the challenge. 😄

@drashna drashna merged commit 8d9f527 into qmk:develop Jun 20, 2021
@dsvensson dsvensson mentioned this pull request Jul 2, 2021
Closed
@firetech firetech deleted the serial_link_sync_timer branch July 12, 2021 15:48
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@firetech @nhongooi
Add sync_timer support over serial_link (i.e. Ergodox Infinity) (qmk#…
8998625 
…12845)
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@firetech
Add sync_timer support over serial_link (i.e. Ergodox Infinity) (qmk#…
df973ae 
…12845)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@firetech @fauxpark @drashna