[Core] ChibiOS fix O3 and LTO breakage of extra keys and joystick #12819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty extra key reports where send form the keyboard when O3 optimizations with LTO where enabled on GCC 10.2 (RISC-V). The root cause should be the pointer to an stack allocated report object which is invalid by the time the report is send. The fix is simple enough, the reports are allocated with a static lifetime, so pointers to them are never invalid. Joystick reports got the same treatment as the pattern is exactly the same.
fauxpark
reviewed
May 6, 2021
fauxpark
approved these changes
May 6, 2021
zvecr
reviewed
May 6, 2021
I'm not sure as I don't have hardware to test the changes, but giving the reports a static lifetime shouldn't hurt, so I'm applying those as well. |
|
What about mousekeys? |
|
Mouse keys worked without any problem. |
drashna
approved these changes
May 10, 2021
14 tasks
|
Thanks! |
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jul 30, 2021
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jul 30, 2021
9 tasks
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Empty extra key reports where send (observed with Wireshark) form the keyboard when O3 optimizations with LTO where enabled on GCC 10.2 (RISC-V). The root cause should be the pointer to an stack allocated report object which is invalid by the time the report is send. The fix is simple enough, the reports are allocated with a static lifetime, so pointers to them are never invalid. Joystick reports got the same treatment as the pattern is exactly the same.
Types of Changes
Issues Fixed or Closed by This PR
Checklist