Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RGB matrix support for Kyria #12789

Merged
merged 5 commits into from
Jul 27, 2021
Merged

Add RGB matrix support for Kyria #12789

merged 5 commits into from
Jul 27, 2021

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented May 3, 2021 •
edited
Loading

Description

This change adds g_led_config struct to Kyria, allowing LEDs to be addressed by RGB_MATRIX_ENABLE features if users enable support in their own configuration.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@filterpaper filterpaper closed this May 3, 2021
@filterpaper filterpaper reopened this May 3, 2021
@drashna drashna requested a review from a team June 20, 2021 01:59
@filterpaper filterpaper changed the base branch from master to develop July 27, 2021 01:25
@filterpaper
Copy link
Contributor Author

Rebased changes to develop to reflect new path.

drashna
drashna requested changes Jul 27, 2021
View reviewed changes
keyboards/splitkb/kyria/rev1/config.h Outdated Show resolved Hide resolved
keyboards/splitkb/kyria/rev1/rules.mk Show resolved Hide resolved
@drashna drashna merged commit be34fde into qmk:develop Jul 27, 2021
@filterpaper filterpaper deleted the kyria_rgbmatrix branch July 27, 2021 10:05
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@filterpaper @drashna @nhongooi
[Keyboard] Add RGB matrix support for Kyria (qmk#12789)
f24102e 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: filterpaper <filterpaper@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @fauxpark