Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backslash in lily58 domnantas keymap #12713

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

domnantas
Copy link

Minor update to personal keymap

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 27, 2021 10:23
@noroadsleft
Copy link
Member

Hm, this keymap doesn't seem to compile:

Making lily58/rev1 with keymap domnantas

avr-gcc.exe (GCC) 8.4.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiling: keyboards/lily58/keymaps/domnantas/keymap.c                                             keyboards/lily58/keymaps/domnantas/keymap.c:67:13: error: conflicting types for 'is_keyboard_left'
 const bool *is_keyboard_left(void);
             ^~~~~~~~~~~~~~~~
In file included from tmk_core/common/action.h:22,
                 from quantum/keymap.h:22,
                 from quantum/quantum.h:30,
                 from keyboards/lily58/rev1/rev1.h:5,
                 from keyboards/lily58/lily58.h:4,
                 from keyboards/lily58/keymaps/domnantas/keymap.c:17:
tmk_core/common/keyboard.h:66:6: note: previous declaration of 'is_keyboard_left' was here
 bool is_keyboard_left(void);
      ^~~~~~~~~~~~~~~~
 [ERRORS]
 |
 |
 |
make[1]: *** [tmk_core/rules.mk:417: .build/obj_lily58_rev1_domnantas/keyboards/lily58/keymaps/domnantas/keymap.o] Error 1
Make finished with errors
make: *** [Makefile:523: lily58/rev1:domnantas] Error 1

Tried this source branch and qmk:master.

@drashna drashna self-requested a review June 7, 2021 05:12
@stale
Copy link

stale bot commented Jul 22, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@fauxpark fauxpark merged commit dfd795e into qmk:master Jul 23, 2021
@fauxpark
Copy link
Member

Thanks!

nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants