Include lib8tion.c into RGB matrix build list #12699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
filterpaper
force-pushed
the
lib8tion_header
branch
from
dd21514
to
66b916a
Compare
zvecr
requested changes
Apr 30, 2021
There was a problem hiding this comment.
My preference is something like
diff --git a/common_features.mk b/common_features.mk
index 8c9d0a90c..917469ced 100644
--- a/common_features.mk
+++ b/common_features.mk
@@ -255,6 +255,7 @@ endif
SRC += $(QUANTUM_DIR)/color.c
SRC += $(QUANTUM_DIR)/rgb_matrix.c
SRC += $(QUANTUM_DIR)/rgb_matrix_drivers.c
+ SRC += $(LIB_PATH)/lib8tion/lib8tion.c
CIE1931_CURVE := yes
RGB_KEYCODES_ENABLE := yes
As this,
- avoids the known issues on gcc10 and fcommon
- adds fewer modifications to the library
Changed as requested. |
filterpaper
changed the title
drashna
approved these changes
May 9, 2021
fauxpark
requested changes
Jul 22, 2021
Added for |
fauxpark
approved these changes
Jul 22, 2021
|
You have a couple of merge conflicts that need to be resolved. |
filterpaper
force-pushed
the
lib8tion_header
branch
2 times, most recently
from
cc7f0d9
to
98d636b
Compare
Sorry I missed those. Conflicts are resolved. |
filterpaper
force-pushed
the
lib8tion_header
branch
from
4f4b337
to
6a911a5
Compare
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
Co-authored-by: filterpaper <filterpaper@localhost>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Co-authored-by: filterpaper <filterpaper@localhost>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Random functions in lib8tion's
random8.hrequires the variablerand16seedthat is externally initialised inlib8tion.c. Included that as part of source files to be built withRGB_MATRIX_ENABLE.Types of Changes
Checklist