Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit saturation for RGB_MATRIX_JELLYBEAN_RAINDROPS #12669

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Limit saturation for RGB_MATRIX_JELLYBEAN_RAINDROPS #12669

merged 4 commits into from
Jun 16, 2021

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Apr 24, 2021 •
edited
Loading

Description

The rand() function for HSV saturation of Jellybean Raindrops covers 0-255 range, resulting with mostly white effect. This change limit saturation above 0x7F (127) to ensure colors are always visible.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Apr 24, 2021
@stale
Copy link

stale bot commented Jun 16, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Jun 16, 2021
@tzarc tzarc changed the base branch from master to develop June 16, 2021 04:03
@tzarc
Copy link
Member

tzarc commented Jun 16, 2021

I know it's a simple change, but because it's targeting core files this will have to go to develop.

@tzarc tzarc merged commit ff61df1 into qmk:develop Jun 16, 2021
@filterpaper filterpaper deleted the jellybean_effects branch June 16, 2021 04:43
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@filterpaper @nhongooi
Limit saturation for RGB_MATRIX_JELLYBEAN_RAINDROPS (qmk#12669)
d7a43c0 
* Set saturation limit to jellybean_raindrops_anim.h

* Use faster bit-shift maths and qadd8

* Remove extra parenthesis

* Single bitmask operation is sufficient.

Co-authored-by: filterpaper <filterpaper@localhost>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@filterpaper
Limit saturation for RGB_MATRIX_JELLYBEAN_RAINDROPS (qmk#12669)
20ef438 
* Set saturation limit to jellybean_raindrops_anim.h

* Use faster bit-shift maths and qadd8

* Remove extra parenthesis

* Single bitmask operation is sufficient.

Co-authored-by: filterpaper <filterpaper@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
awaiting review core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @tzarc @drashna