Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Satisfaction 75 turn off oled on suspend #12657

Closed
wants to merge 1 commit into from
Closed

Satisfaction 75 turn off oled on suspend #12657

wants to merge 1 commit into from

Conversation

MarMed
Copy link

@MarMed MarMed commented Apr 23, 2021

a0089aa makes changes to the OLED, I believe this causes the OLED to freeze and stay on after host suspend, I included the snippet of code that sleeps the OLED within suspend_power_down_user to fix this issue. This may not be the best way, but in my testing it works, open to improvements.

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team May 13, 2021 17:46
drashna
drashna reviewed May 13, 2021
View reviewed changes
keyboards/cannonkeys/satisfaction75/led.c
@@ -19,6 +19,11 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#include "led_custom.h"
#include "satisfaction75.h"

#ifdef QWIIC_MICRO_OLED_ENABLE
#include "micro_oled.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"no such file exists", in travis CI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only for the tester keymap, which has QWIIC_ENABLE = no... but that should result in QWIIC_MICRO_OLED_ENABLE not being defined: https://github.com/qmk/qmk_firmware/blob/master/drivers/qwiic/qwiic.mk

@tzarc
Copy link
Member

tzarc commented Jun 24, 2021

@awkannan can you confirm you're okay with this patch?

@stale
Copy link

stale bot commented Aug 10, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@MarMed
Copy link
Author

MarMed commented Aug 24, 2021

Is there anything I can do to help get this PR reviewed?

@MarMed MarMed requested a review from fauxpark September 26, 2021 21:58
@fauxpark
Copy link
Member

Potentially obsoleted by #14174

@tzarc
Copy link
Member

tzarc commented Nov 5, 2021

Potentially obsoleted by #14174

Definitely obsoleted. Next merge from develop will swap Satisfaction75 to the normal OLED driver, which has timeout already present.

Closing.

@tzarc tzarc closed this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarMed @tzarc @fauxpark @drashna