Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard Light - Add keyboard, basic keymap #12654

Merged
merged 36 commits into from
Jul 20, 2021
Merged

Hard Light - Add keyboard, basic keymap #12654

merged 36 commits into from
Jul 20, 2021

Conversation

FateEverywhere
Copy link
Contributor

Description

Completed changes and style updates as requested by ridingqwerty. Additionally, adjusted directory structure to allow for the next Everywhere Defense Industries board that I intend to release.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

FateEverywhere and others added 8 commits April 22, 2021 11:10
@FateEverywhere
Hard Light Mk I initial upload
2106b67 
Contains only default keymap. User-customized maps designed for testers and my own with leader key password sequences aren't here for obvious reasons.
@FateEverywhere @ridingqwerty
Update keyboards/hardlight/config.h
0ea0b36 
Co-authored-by: ridingqwerty <[email protected]>
@FateEverywhere @ridingqwerty
Update keyboards/hardlight/keymaps/default/config.h
4290826 
Co-authored-by: ridingqwerty <[email protected]>
@FateEverywhere @ridingqwerty
Update keyboards/hardlight/keymaps/default/keymap.c
b7299fd 
Co-authored-by: ridingqwerty <[email protected]>
@FateEverywhere
Changes for purpose of pull request
6e1e887 
Completed updates and changes as requested by ridingqwerty.
@FateEverywhere
Merge branch 'hardlight' of https://github.com/FateEverywhere/qmk_fir…
2eb267c 
…mware into hardlight
@FateEverywhere
Updated folder structure
392a52f 
Updated to conform with recommended practice - EDI will be bringing other boards to the community.
@FateEverywhere
Update readme.md
1aec2eb 
Update readme for new directory structure
ridingqwerty
ridingqwerty requested changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better, though there are a few suggestions I had made in the first PR that didn't make their way into this one, so I put them again. You can just click the button on the suggestion to automagically implement it.

For the license header, we generally request some kind of copyright/attribution in the beginning, e.g. Copyright 2018 Jack Humbert <[email protected]> -- but I am having trouble finding this explicitly mentioned in the PR checklist. Sorry for not mentioning before.

keyboards/edi/hardlight/hardlight.h Outdated Show resolved Hide resolved
keyboards/edi/hardlight/hardlight.h Outdated Show resolved Hide resolved
keyboards/edi/hardlight/hardlight.h Outdated Show resolved Hide resolved
FateEverywhere
FateEverywhere commented Apr 22, 2021
View reviewed changes
Copy link
Contributor Author

@FateEverywhere FateEverywhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates done as requested - Copyright lines added, all others resolved by button. Hooray, buttons!

@FateEverywhere
Changes requested complete.
ac6b01f 
Copyright notices added, and other changes made as requested by ridingqwerty.
@FateEverywhere FateEverywhere changed the title Hardlight - Changes from prior pull request Hardlight - Add keyboard, basic keymap May 14, 2021
@FateEverywhere FateEverywhere changed the title Hardlight - Add keyboard, basic keymap Hard Light - Add keyboard, basic keymap May 14, 2021
zvecr
zvecr requested changes May 14, 2021
View reviewed changes
keyboards/edi/hardlight/rules.mk Outdated Show resolved Hide resolved
keyboards/edi/hardlight/hardlight.c Outdated Show resolved Hide resolved
keyboards/edi/hardlight/config.h Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team May 14, 2021 00:27
FateEverywhere and others added 3 commits May 13, 2021 20:31
@FateEverywhere @zvecr
Update keyboards/edi/hardlight/rules.mk
f5fa3a7 
LEADER_ENABLE is now a keyboard-level option.

Co-authored-by: Joel Challis <[email protected]>
@FateEverywhere @zvecr
Update keyboards/edi/hardlight/hardlight.c
8e9ebf2 
Co-authored-by: Joel Challis <[email protected]>
@FateEverywhere @zvecr
Update keyboards/edi/hardlight/config.h
6974fdf 
Co-authored-by: Joel Challis <[email protected]>
FateEverywhere
FateEverywhere commented May 27, 2021
View reviewed changes
Copy link
Contributor Author

@FateEverywhere FateEverywhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, committed latest sets of requests.

fauxpark
fauxpark reviewed May 28, 2021
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jul 12, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Jul 13, 2021
@FateEverywhere FateEverywhere requested review from fauxpark and zvecr July 13, 2021 13:26
@FateEverywhere
Removed my keymap, edited readme.
1830585 
Mark 1 is what's being uploaded, and so I changed the readme to include that.
fauxpark
fauxpark requested changes Jul 13, 2021
View reviewed changes
keyboards/edi/hardlight/Mk1/readme.md Outdated Show resolved Hide resolved
keyboards/edi/hardlight/Mk1/readme.md Outdated Show resolved Hide resolved
keyboards/edi/hardlight/Mk1/hardlight.c Outdated Show resolved Hide resolved
fauxpark
fauxpark approved these changes Jul 13, 2021
View reviewed changes
keyboards/edi/hardlight/mk1/config.h Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Jul 20, 2021

Thanks!

@drashna drashna merged commit 16e5298 into qmk:master Jul 20, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@FateEverywhere @ridingqwerty
@zvecr @fauxpark @nhongooi
[Keyboard] Hard Light - Add keyboard, basic keymap (qmk#12654)
8a8326c 
Co-authored-by: ridingqwerty <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FateEverywhere @drashna @fauxpark @ridingqwerty @zvecr