Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameBuddy v1.M #12637

Merged
merged 37 commits into from
Jul 20, 2021
Merged

GameBuddy v1.M #12637

merged 37 commits into from
Jul 20, 2021

Conversation

AlisGraveNil
Copy link
Contributor

Description

I created the GameBuddy Mirror Series version.
I moved the original GameBuddy files into a "rev1.0" folder and added the "rev1.M" folder for the Mirror version.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v1.0 folder would need to have the gamebuddy.c/h file names changed too.

And moving everything around like this means that this needs to target the develop branch, rather than the master branch.

keyboards/clawsome/gamebuddy/v1.M/gamebuddy_rev1M.c Outdated Show resolved Hide resolved
keyboards/clawsome/gamebuddy/v1.M/gamebuddy_rev1M.c Outdated Show resolved Hide resolved
keyboards/clawsome/gamebuddy/v1.M/gamebuddy_rev1M.h Outdated Show resolved Hide resolved
@AlisGraveNil
Copy link
Contributor Author

I have no idea what 'develop branch' means in this context; did I need to make a fork of a different master?

@AlisGraveNil
Copy link
Contributor Author

@drashna - do I need to delete this PR to recreate it in the 'develop' branch?

@drashna
Copy link
Member

drashna commented May 27, 2021

https://docs.qmk.fm/#/breaking_changes_instructions

And no, you don't need to delete it. If you edit the title, it will let you choose a different branch to target in the QMK repo. Select develop, and save. After doing so, you may need to rebase your branch. This guide should cover all of the rebasing stuff:
https://docs.qmk.fm/#/newbs_git_best_practices

@AlisGraveNil AlisGraveNil changed the base branch from master to develop May 27, 2021 22:12
@AlisGraveNil
Copy link
Contributor Author

@drashna - did I move it right?

@drashna
Copy link
Member

drashna commented May 30, 2021

Yup!

@drashna drashna requested a review from a team May 30, 2021 20:16
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.s in the keyboard file/folder names should be changed to _s.

@AlisGraveNil
Copy link
Contributor Author

.s in the keyboard file/folder names should be changed to _s.

I seem to have been able to rename all of the files except "1.M.c"
I tried completely renaming the file then going back, no dice.
Any suggestions?

keyboards/clawsome/gamebuddy/v1_M.M/v1_M.c Outdated Show resolved Hide resolved
keyboards/clawsome/gamebuddy/v1_0/v1_0.c Outdated Show resolved Hide resolved
keyboards/clawsome/gamebuddy/v1.M.c Outdated Show resolved Hide resolved
@AlisGraveNil
Copy link
Contributor Author

@fauxpark do I need to change "." to "_" in all files, or just the three you suggested changes to?

@fauxpark
Copy link
Member

fauxpark commented Jun 1, 2021

All files and folders must be lowercase, with no .s, and files that reference them (eg. #includes) need to match.

@AlisGraveNil
Copy link
Contributor Author

Okay, I think I got all the bits you were referencing

@AlisGraveNil
Copy link
Contributor Author

@fauxpark - anything else I need to do on this?

@AlisGraveNil
Copy link
Contributor Author

@fauxpark - I cannot get the folder to get rid of the ".M" suffix, no matter what I change the folder name to. Any suggestions?

@fauxpark
Copy link
Member

fauxpark commented Jul 9, 2021

I cloned your repo to try it myself - this seems to work fine:

git mv keyboards/clawsome/gamebuddy/v1_m.M keyboards/clawsome/gamebuddy/v1_m

@AlisGraveNil
Copy link
Contributor Author

@fauxpark that worked! thank you!

keyboards/clawsome/gamebuddy/v1_M/config.h Outdated Show resolved Hide resolved
keyboards/clawsome/gamebuddy/v1_M/readme.md Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team July 20, 2021 17:06
@drashna
Copy link
Member

drashna commented Jul 20, 2021

Thanks!

@drashna drashna merged commit c98e258 into qmk:develop Jul 20, 2021
@AlisGraveNil
Copy link
Contributor Author

@drashna - now that this is merged into 'develop'... what does it do?

nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants