-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GameBuddy v1.M #12637
GameBuddy v1.M #12637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The v1.0 folder would need to have the gamebuddy.c/h file names changed too.
And moving everything around like this means that this needs to target the develop branch, rather than the master branch.
I have no idea what 'develop branch' means in this context; did I need to make a fork of a different master? |
@drashna - do I need to delete this PR to recreate it in the 'develop' branch? |
https://docs.qmk.fm/#/breaking_changes_instructions And no, you don't need to delete it. If you edit the title, it will let you choose a different branch to target in the QMK repo. Select |
@drashna - did I move it right? |
14b3099
to
974d4af
Compare
Yup! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
s in the keyboard file/folder names should be changed to _
s.
I seem to have been able to rename all of the files except "1.M.c" |
@fauxpark do I need to change "." to "_" in all files, or just the three you suggested changes to? |
All files and folders must be lowercase, with no |
Okay, I think I got all the bits you were referencing |
@fauxpark - anything else I need to do on this? |
0191424
to
ace58f5
Compare
@fauxpark - I cannot get the folder to get rid of the ".M" suffix, no matter what I change the folder name to. Any suggestions? |
I cloned your repo to try it myself - this seems to work fine:
|
@fauxpark that worked! thank you! |
Co-authored-by: Ryan <[email protected]>
Thanks! |
@drashna - now that this is merged into 'develop'... what does it do? |
Co-authored-by: Ryan <[email protected]>
Description
I created the GameBuddy Mirror Series version.
I moved the original GameBuddy files into a "rev1.0" folder and added the "rev1.M" folder for the Mirror version.
Types of Changes
Issues Fixed or Closed by This PR
Checklist