Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VIA support to dmqdesign/spin #12300

Merged
merged 4 commits into from
Apr 3, 2021
Merged

Added VIA support to dmqdesign/spin #12300

merged 4 commits into from
Apr 3, 2021

Conversation

adamkraus6
Copy link

@adamkraus6 adamkraus6 commented Mar 19, 2021

Description

Added VIA support to dmqdesign/spin. Tested on own board.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Mar 19, 2021
@fauxpark fauxpark requested a review from a team March 25, 2021 07:10
@fauxpark fauxpark requested a review from a team March 25, 2021 15:08
@drashna drashna merged commit 0232941 into qmk:master Apr 3, 2021
@drashna
Copy link
Member

drashna commented Apr 3, 2021

Thanks!

For future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

Fixing Your Branch will walk you through fixing up your master branch moving forward. If you need any help with this just ask.

Thanks for contributing!

makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants