Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ferris 0.2 #12133

Merged
merged 10 commits into from
Apr 18, 2021
Merged

Add ferris 0.2 #12133

merged 10 commits into from
Apr 18, 2021

Conversation

pierrechevalier83
Copy link
Contributor

@pierrechevalier83 pierrechevalier83 commented Mar 6, 2021

Description

The Ferris 0.2 switches from an atmega32u4 chip to an stm32f072 chip.

Write firmware for this. The most challenging bit was to configure i2c
as the hardware uses the i2c2 pins: PB10 and PB11 which is uncommon.

The ferris bling has backlighting leds which are not supported yet.
Support will come in a later PR.

Note that part of this change refactors the 0.1's matrix.c implementation for
consistency as only higher level functions are available to call with chibios
and I prefer to have code that is closer to each other between revisions.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Use higher level functions of the i2c API to simplify my matrix.c
implementation.
The Ferris 0.2 switches from an atmega32u4 chip to an stm32f072 chip.

Write firmware for this. The most challenging bit was to configure i2c
as the hardware uses the i2c2 pins: PB10 and PB11 which is uncommon.

The ferris bling has backlighting leds which are not supported yet.
Support will come in a later PR.
@pierrechevalier83
Copy link
Contributor Author

Is there anything holding this PR from getting merged? It looks like it was approved 13 days ago. When it's in, I'll want to raise a follow-up PR for the underglow :)

@drashna drashna requested a review from a team April 3, 2021 00:26
@drashna
Copy link
Member

drashna commented Apr 3, 2021

Is there anything holding this PR from getting merged? It looks like it was approved 13 days ago. When it's in, I'll want to raise a follow-up PR for the underglow :)

Just time. We review PRs in our spare time, so it can take some time.

keyboards/ferris/0_1/readme.md Outdated Show resolved Hide resolved
keyboards/ferris/0_2/config.h Outdated Show resolved Hide resolved
keyboards/ferris/0_2/readme.md Outdated Show resolved Hide resolved
keyboards/ferris/keymaps/test/readme.md Outdated Show resolved Hide resolved
keyboards/ferris/readme.md Outdated Show resolved Hide resolved
keyboards/ferris/sweep/readme.md Outdated Show resolved Hide resolved
@pierrechevalier83
Copy link
Contributor Author

Is there anything holding this PR from getting merged? It looks like it was approved 13 days ago. When it's in, I'll want to raise a follow-up PR for the underglow :)

Just time. We review PRs in our spare time, so it can take some time.

Hi @drashna , thanks for the reply. I'm sorry if I sounded impatient. I totally appreciate the time you all are spending on maintaining this huge project for the benefit of the hobbyist keyboard community. I also appreciate that so far I've been getting great quality code reviews in all of my PRs and people have been really helpful on discord when I had questions ❤️

I guess my question was more about the process than just the timeline: do PRs need two approving reviews before landing? I haven't found a clear indication here: https://docs.qmk.fm/#/contributing, so it's a bit hard to know what to expect. Maybe I haven't been looking at the right place in the documentation to find this kind of information?

@pierrechevalier83
Copy link
Contributor Author

Thanks for the review, @fauxpark. I've committed all of your suggestions 👍 I learnt something about controlling the size of an imgur image preview today 😄

@drashna
Copy link
Member

drashna commented Apr 9, 2021

Is there anything holding this PR from getting merged? It looks like it was approved 13 days ago. When it's in, I'll want to raise a follow-up PR for the underglow :)

Just time. We review PRs in our spare time, so it can take some time.

Hi @drashna , thanks for the reply. I'm sorry if I sounded impatient. I totally appreciate the time you all are spending on maintaining this huge project for the benefit of the hobbyist keyboard community. I also appreciate that so far I've been getting great quality code reviews in all of my PRs and people have been really helpful on discord when I had questions ❤️

I guess my question was more about the process than just the timeline: do PRs need two approving reviews before landing? I haven't found a clear indication here: docs.qmk.fm/#/contributing, so it's a bit hard to know what to expect. Maybe I haven't been looking at the right place in the documentation to find this kind of information?

No worries. And yeah, we generally want 2 approvals before a PR is merged in.

And I've been meaning to add that info to the docs.

@Erovia Erovia merged commit d0973e1 into qmk:master Apr 18, 2021
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
rizo pushed a commit to rizo/qmk_firmware that referenced this pull request May 10, 2021
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants