Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for non-assignment code in rules.mk #12108

Merged
merged 5 commits into from
Aug 29, 2021
Merged

Add check for non-assignment code in rules.mk #12108

merged 5 commits into from
Aug 29, 2021

Conversation

skullydazed
Copy link
Member

Description

As part of what we discussed in #8422 this adds a check for keyboard level rules.mk files to ensure that only assignment rules are present. We can change the name to whatever we decide on in.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Mar 4, 2021
@skullydazed skullydazed requested a review from a team March 4, 2021 07:13
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, but LGTM otherwise.

@Erovia Erovia requested a review from a team May 9, 2021 10:47
@tzarc
Copy link
Member

tzarc commented Jun 23, 2021

So is this waiting for #8422 before merge? Preventing non-assignment options without a workable alternative implementation won't fly.

@skullydazed
Copy link
Member Author

Yes, we actually need the post processing file before this can be merged.

@tzarc tzarc merged commit 566d598 into develop Aug 29, 2021
@tzarc tzarc deleted the rules_lint branch August 29, 2021 02:38
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Sep 2, 2021
* qmk/develop:
  Remove bin/qmk (qmk#14231)
  ensure that the directory for sys.executable is in the user's path (qmk#14229)
  move everything from qmkfm/base_container to qmkfm/qmk_cli (qmk#14230)
  Nyquist (qmk#14202)
  Update the nix-shell environment (qmk#13316)
  [Keyboard] Add Viktus SP Mini (qmk#14069)
  [Keyboard] Corrected layout for np24 by YMDK (qmk#14096)
  [Keymap] My Prime E keymap (qmk#14117)
  [Keyboard] Add kelownaRGB64 (qmk#14141)
  [Keyboard] fix compile error `make helix/rev2/sc:all` (qmk#14214)
  fix automatic directory for qmk lint (qmk#14215)
  Add check for non-assignment code in rules.mk (qmk#12108)
  remove qmk console, which is now part of the global cli (qmk#14206)
  Fixup upstream paths for submodules. (qmk#14205)
  Bootmagic lite docs clarity. (qmk#14204)
  add 'include keyboard_features.mk' into build_keyboard.mk (qmk#8422)
  2021Q3 pre-merge `develop` changelog, keyboard aliases (qmk#14198)
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
* Add check for non-assignment code in rules.mk

* fix lint check

* fix lint

* fixup to reflect the final state of qmk#8422

* fix lint
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Add check for non-assignment code in rules.mk

* fix lint check

* fix lint

* fixup to reflect the final state of qmk#8422

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants