-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Meridian RGB indicators for varying hardware across PCB batches. #11812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also v1.1
is currently an invalid keyboard name so would have to be something like v1_1
build errors in continuous-integration/travis-ci/pr are due to my changes in drivers/chibios/ws2812.c not being present yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also as a passing comment, the rev1 now using the bitbang driver seems like a step backwards. And use of rgblight layers at the keyboard level seems a tad meh.
Well, updating them should be just running qmk chibosconf, I think it was. But you roll back commits and force push, or revert them, to fix issues. |
Thank you for your contribution! |
Thank you for your contribution! |
Use TIM1_CH3N instead of TIM15_CH2, because TIM15 on F072 is apparently not supported properly in ChibiOS 20.3.3. Also try to adjust some WS2812 timings as suggested in qmk#11812 (but not T1H yet - that would also require changes in the WS2812 PWM driver).
Two different LED parts were used by the manufacturer creating a firmware issue. This update helps to correct this by making two different firmware versions. A small change was made to drivers/chibios/ws2812.c to make this possible.
WS2812 driver was also changed from SPI to bitbang due to an apparent issue with SPI introduced since the Meridian firmware was initially merged.
Types of Changes
Issues Fixed or Closed by This PR
#11755
Checklist