Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA keymap to duckyPad, update M4cs keymap for duckyPad #11703

Merged
merged 29 commits into from
Feb 16, 2021
Merged

Add VIA keymap to duckyPad, update M4cs keymap for duckyPad #11703

merged 29 commits into from
Feb 16, 2021

Conversation

M4cs
Copy link
Contributor

@M4cs M4cs commented Jan 27, 2021 •
edited
Loading

Description

Adds VIA support for duckyPad macropads. Also updates my personal keymap to include my systeminfo layer. This also adds a python script to my keymap folder.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

M4cs and others added 23 commits November 5, 2020 20:25
@github-actions github-actions bot added core keyboard keymap python via Adds via keymap and/or updates keyboard for via support labels Jan 27, 2021
zvecr
zvecr requested changes Jan 27, 2021
View reviewed changes
tmk_core/protocol/usb_descriptor.h Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/keymaps/via/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team January 27, 2021 15:00
@github-actions github-actions bot removed the core label Jan 27, 2021
@M4cs M4cs mentioned this pull request Jan 27, 2021
Merged
6 tasks
@M4cs M4cs requested review from zvecr and removed request for a team January 28, 2021 22:01
@M4cs M4cs requested review from fauxpark and drashna February 1, 2021 06:02
fauxpark
fauxpark requested changes Feb 1, 2021
View reviewed changes
keyboards/dekunukem/duckypad/config.h Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/keymaps/m4cs/keymap.c Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/keymaps/m4cs/keymap.c Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/duckypad.h Show resolved Hide resolved
@M4cs M4cs requested a review from fauxpark February 1, 2021 15:39
@M4cs
Copy link
Contributor Author

M4cs commented Feb 7, 2021

Is it possible to bump this up? I've made revisions for all requested changes

fauxpark
fauxpark requested changes Feb 7, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@M4cs
Copy link
Contributor Author

M4cs commented Feb 8, 2021

.

Fixed thanks

@M4cs M4cs requested a review from fauxpark February 11, 2021 15:57
@M4cs
Copy link
Contributor Author

M4cs commented Feb 16, 2021 •
edited
Loading

@zvecr Would you be able to approve my changes please? Thanks!

@drashna drashna merged commit ac33dc1 into qmk:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap python via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@M4cs @drashna @fauxpark @zvecr @frenchie0x4ff