Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two keyboards #11696

Merged
merged 56 commits into from
Feb 16, 2021
Merged

Added two keyboards #11696

merged 56 commits into from
Feb 16, 2021

Conversation

andresteare
Copy link

@andresteare andresteare commented Jan 26, 2021

Hi! I'm just a keyboard enthusiast that converted two keyboard (one with a dead MCU and a typewriter) to run with a Teensy! The keyboards are:

  • Gamdias 7 colors fullsize iso keyboard
  • IBM 6715 typewriter with (buckling springs!)

Note on the IBM one: both shift keys share the same circuit so, to avoid any confussion, I excluded RShift from the keymap (I put bigger warning in the README)

Both of them work flawlessly, I started the idea of supporting the community because I gave the Gamdias to a friend who doesn't even know what QMK is so having the keyboard officially supported by the online configurator would be very helpful. But then decided to pull all the keyboard, because why not help the community :)

I'm a noob when it comes to github, so I hope my request meets the expected standars :)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [x ] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. (I'm not sure what you mean by cover but I test and compile after every change I make)
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

got a dead keyboard for $8 and make it work with QMK with help of a teensy

Keymap works great but haven't managed to make backlight work properly, but I still included the resistors connected to the LED you need to wire to
Made the firmware and the keymap through Keyboard Firmware Builder, didn't include the right shift, becaused it shared the circuit with the left one
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 26, 2021
keyboards/handwired/ibm_wheelwriter/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/oem_iso_fullsize/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/ibm122m/keymaps/andresteare/keymap.c Outdated Show resolved Hide resolved
@andresteare
Copy link
Author

andresteare commented Feb 16, 2021

So what's next? I have 2 approvals and all checks passed

@drashna
Copy link
Member

drashna commented Feb 16, 2021

Just for somebody to merge it. :)

@drashna drashna merged commit d754266 into qmk:master Feb 16, 2021
@andresteare
Copy link
Author

Just for somebody to merge it. :)

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants