Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated housekeeping call from arm_atsam #11672

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

Gentoli
Copy link

@Gentoli Gentoli commented Jan 23, 2021

Description

Patch for #10530 (comment)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 23, 2021
@tzarc tzarc merged commit 28b1c91 into qmk:develop Jan 24, 2021
@tzarc
Copy link
Member

tzarc commented Jan 24, 2021

Thanks!

@Gentoli Gentoli deleted the atsam-housekeeping branch January 24, 2021 09:24
@mtei
Copy link
Contributor

mtei commented Mar 18, 2021

There seems to be other duplication. (At #12206 I asked about this.)

% git checkout  28b1c91
% git checkout  HEAD^
% find tmk_core quantum -name \*.c | xargs grep housekeep
tmk_core/common/keyboard.c:/** \brief housekeeping_task_kb
tmk_core/common/keyboard.c:__attribute__((weak)) void housekeeping_task_kb(void) {}
tmk_core/common/keyboard.c:/** \brief housekeeping_task_user
tmk_core/common/keyboard.c:__attribute__((weak)) void housekeeping_task_user(void) {}
tmk_core/common/keyboard.c:    housekeeping_task_kb();
tmk_core/common/keyboard.c:    housekeeping_task_user();
tmk_core/protocol/arm_atsam/main_arm_atsam.c:        // Run housekeeping
tmk_core/protocol/arm_atsam/main_arm_atsam.c:        housekeeping_task_kb();
tmk_core/protocol/arm_atsam/main_arm_atsam.c:        housekeeping_task_user();
tmk_core/protocol/chibios/main.c:        // Run housekeeping
tmk_core/protocol/chibios/main.c:        housekeeping_task_kb();
tmk_core/protocol/chibios/main.c:        housekeeping_task_user();
tmk_core/protocol/lufa/lufa.c:        // Run housekeeping
tmk_core/protocol/lufa/lufa.c:        housekeeping_task_kb();
tmk_core/protocol/lufa/lufa.c:        housekeeping_task_user();
tmk_core/protocol/vusb/main.c:            // Run housekeeping
tmk_core/protocol/vusb/main.c:            housekeeping_task_kb();
tmk_core/protocol/vusb/main.c:            housekeeping_task_user();

BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants