Switch to nano specs on ChibiOS builds - Round 2 #11607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, running through a |
|
Found a couple of issues with the syscall stuff, raised #11608 as a response. |
tzarc
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
-------------------------------
Successful builds: 125
Warning builds: 5
Failing builds: 0
-------------------------------
Unsure if we need to get #11608 included with it, the tkc/candybar's were failing with a mismatching _kill() signature for some reason... it was wrong, but I have no idea why nothing else complained.
zvecr
force-pushed
the
feature/nano_specs_round_2
branch
from
fa962ef to
f229144
Compare
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #11573, this could be worth another try... maybe (#9044 for the previous iteration).
Types of Changes
Checklist