Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate manufacturer definitions #11544

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Remove duplicate manufacturer definitions #11544

merged 1 commit into from
Jan 14, 2021

Conversation

skullydazed
Copy link
Member

Description

Now that the integration between info.json and config.h is tighter we should define these variables in only one place. I chose to leave this in config.h under the principle of least surprise.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team January 13, 2021 22:26
@github-actions github-actions bot added cli qmk cli command core documentation keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support labels Jan 13, 2021
@skullydazed skullydazed changed the base branch from master to develop January 13, 2021 22:26
@skullydazed skullydazed merged commit f4cf0d2 into develop Jan 14, 2021
@skullydazed skullydazed deleted the fixup_manufacturer branch January 14, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
cli qmk cli command core documentation keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skullydazed @drashna @fauxpark