Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for specifying BOARD in info.json #11492

Merged
merged 4 commits into from
Jan 10, 2021
Merged

Add support for specifying BOARD in info.json #11492

merged 4 commits into from
Jan 10, 2021

Conversation

skullydazed
Copy link
Member

Description

BOARD was added while I was working on my data driven qmk project. This adds support for specifying it in info.json like everything else.

Types of Changes

  • Core
  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team January 9, 2021 23:42
@github-actions github-actions bot added cli qmk cli command keyboard python labels Jan 9, 2021
@skullydazed skullydazed marked this pull request as ready for review January 9, 2021 23:57
@tzarc tzarc requested a review from a team January 10, 2021 03:13
@skullydazed skullydazed merged commit eaa9106 into develop Jan 10, 2021
@skullydazed skullydazed deleted the info_json_board branch January 10, 2021 04:18
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed
Add support for specifying BOARD in info.json (qmk#11492)
feaa6b4 
* add support for specifying BOARD in info.json

* move BOARD from rules.mk to info.json for clueboard

* fix keyboards that do not require board

* remove out of compliance values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
cli qmk cli command keyboard python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skullydazed @drashna @tzarc