Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken keyboards #11412

Merged
merged 2 commits into from
Jan 3, 2021
Merged

Fix broken keyboards #11412

merged 2 commits into from
Jan 3, 2021

Conversation

skullydazed
Copy link
Member

Description

My recent PR broke a few keyboards, this addresses the breakage.

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed changed the base branch from master to develop January 3, 2021 01:39
@github-actions github-actions bot added cli qmk cli command keyboard python labels Jan 3, 2021
@skullydazed skullydazed requested a review from a team January 3, 2021 01:39
@github-actions github-actions bot added the core label Jan 3, 2021
@tzarc tzarc merged commit 11bd98f into develop Jan 3, 2021
@tzarc tzarc deleted the fix_broken_keyboards branch January 3, 2021 02:08
fauxpark
fauxpark reviewed Jan 3, 2021
View reviewed changes
keyboards/jm60/jm60.h
@@ -35,7 +35,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
* | 40 | 41 | 42 | 46 | 4a | 4b | 4c | 4d |
* `-----------------------------------------------------------'
*/
#define KEYMAP_ANSI( \
#define LAYOUT_ansi( \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already broken; I'm planning to refactor a bunch of boards in #10792.

@fauxpark fauxpark mentioned this pull request Jan 3, 2021
Merged
14 tasks
@skullydazed skullydazed mentioned this pull request Jan 4, 2021
Closed
7 tasks
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed
Fix broken keyboards (qmk#11412)
27153e0 
* Fix a couple errors

* add a dependency for the generated headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command core keyboard python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skullydazed @tzarc @fauxpark