-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable visualizer support for ergodox infinity #1127
Conversation
Cool - @fredizzimo, what are you thoughts on this? |
I've been using this as my daily driver for a few days without any real issues. The only problem I've ran into is the state syncing across halves can be slow and inconsistent. On my device, I disabled sharing the state, so only the master half's visualizer updates. The slave stays on the last keyframe of the initialization animation. I'd be happy to make a flag to toggle state sharing across halves and add it to this pull request. |
I will check this out, and make sure everything works as it should. I think at least #1122 should be fixed first. There should also be at least some default visualizer example and documentation. I'll make this a priority over my other work with the effect system. Better get this working first, as it probably still will take some while until the effect system is ready. |
I think this can be closed now, right @fredizzimo? |
Yes. My pull request does all this (well actually fixes the oneshot timeout bug instead of working around it) and more. |
Perfect - thanks guys :) |
* Update Keycode List Per qmk/qmk_firmware Pull Requests qmk#14726 & qmk#15968. - change `KC_SLCK` to `KC_SCRL` - change `KC_NLCK` to `KC_NUM` - change `KC_RO` to `KC_INT1` - change `KC_KANA` to `KC_INT2` - change `KC_JYEN` to `KC_INT3` - change `KC_HENK` to `KC_INT4` - change `KC_MHEN` to `KC_INT5` - change `KC_HAEN` to `KC_LNG1` - change `KC_HANJ` to `KC_LNG2` - change `RESET` to `QK_BOOT` - change `DEBUG` to `DB_TOGG` - change `EEP_RST` to `EE_CLR` - change `KC_GESC` to `QK_GESC` * update keymaps to use KC_SCRL * update keymaps to use KC_NUM * update keymaps to use KC_INT1 * update keymaps to use KC_INT2 * update keymaps to use KC_INT3 * update keymaps to use KC_INT4 * update keymaps to use KC_INT5 * update keymaps to use KC_LNG1 * update keymaps to use KC_LNG2 * update keymaps to use QK_BOOT, 0-9 * update keymaps to use QK_BOOT, A * update keymaps to use QK_BOOT, B * update keymaps to use QK_BOOT, C * update keymaps to use QK_BOOT, D * update keymaps to use QK_BOOT, E * update keymaps to use QK_BOOT, F-G * update keymaps to use QK_BOOT, H * update keymaps to use QK_BOOT, I-J * update keymaps to use QK_BOOT, K * update keymaps to use QK_BOOT, L * update keymaps to use QK_BOOT, M * update keymaps to use QK_BOOT, N-O * update keymaps to use QK_BOOT, P-Q * update keymaps to use QK_BOOT, R * update keymaps to use QK_BOOT, S * update keymaps to use QK_BOOT, T-V * update keymaps to use QK_BOOT, W-X * update keymaps to use QK_BOOT, Y-Z * update keymaps to use DB_TOGG * update keymaps to use EE_CLR * update keymaps to use QK_GESC, 0-9 & A-D * update keymaps to use QK_GESC, E-J * update keymaps to use QK_GESC, K-L * update keymaps to use QK_GESC, M-P * update keymaps to use QK_GESC, R-Z * update keycode list in keyboard tester
Fixes a couple instances that should have been changed in qmk#1127.
A few people have requested this, and it certainly works well enough.