Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix media key missing upstroke event #11162

Merged
merged 1 commit into from
Feb 7, 2021
Merged

[Bug] Fix media key missing upstroke event #11162

merged 1 commit into from
Feb 7, 2021

Conversation

ulex
Copy link

@ulex ulex commented Dec 8, 2020 •
edited by zvecr
Loading

[Bug] Pressing media key on a momentarily activated layer may leads to missing key up events.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ulex
Fix #11161
82ee150 
[Bug] Pressing media key on a momentarily activated layer may leads to
missing key up events.
@github-actions github-actions bot added the core label Dec 8, 2020
@zvecr zvecr changed the title Fix #11161 [Bug] Pressing media key on a momentarily activated layer may leads to missing key up events. Dec 8, 2020
@drashna drashna requested a review from a team December 9, 2020 02:32
@drashna drashna requested a review from a team December 23, 2020 03:57
@drashna drashna requested a review from a team December 23, 2020 06:41
@stale
Copy link

stale bot commented Feb 6, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@ulex
Copy link
Author

ulex commented Feb 6, 2021

is anything required on my part?

@drashna drashna changed the title [Bug] Pressing media key on a momentarily activated layer may leads to missing key up events. [Bug] Fix media key missing upstroke event Feb 7, 2021
@drashna drashna merged commit 9146d30 into qmk:develop Feb 7, 2021
@stale stale bot removed the awaiting changes label Feb 7, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@ulex
[Bug] Fix media key missing upstroke event (qmk#11162)
98dade1 
[Bug] Pressing media key on a momentarily activated layer may leads to
missing key up events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulex @drashna @fauxpark