Update reference_info_json.md #10513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
key_count is now an optional field because it is better to get the keycount by counting the elements in the layout array.
noroadsleft
reviewed
Oct 2, 2020
|
Updated the Japanese documentation as well |
noroadsleft
approved these changes
Oct 2, 2020
zvecr
approved these changes
Oct 2, 2020
|
Thanks! |
rgoulter
pushed a commit
to rgoulter/qmk_firmware
that referenced
this pull request
Oct 4, 2020
* Update reference_info_json.md key_count is now an optional field because it is better to get the keycount by counting the elements in the layout array. * Updated Japanese documentation as well
kjganz
pushed a commit
to kjganz/qmk_firmware
that referenced
this pull request
Oct 28, 2020
* Update reference_info_json.md key_count is now an optional field because it is better to get the keycount by counting the elements in the layout array. * Updated Japanese documentation as well
oscarcarlsson
pushed a commit
to oscarcarlsson/qmk_firmware
that referenced
this pull request
Nov 2, 2020
* Update reference_info_json.md key_count is now an optional field because it is better to get the keycount by counting the elements in the layout array. * Updated Japanese documentation as well
openfirmware
added a commit
to openfirmware/qmk_firmware
that referenced
this pull request
Dec 10, 2020
The longer name will make it clearer where the define is kept in the keyboards directory. `key_count` is removed as it is optional (qmk#10513) and can be auto-counted by reading the layout array.
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Update reference_info_json.md key_count is now an optional field because it is better to get the keycount by counting the elements in the layout array. * Updated Japanese documentation as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key_count is now an optional field because it is better to get the keycount by counting the elements in the layout array.
Description
This came up on one of my pull requests, I just wanted to update it here so the documentation matches
Types of Changes
Checklist