Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip transport for another matrix based on error count #10468

Closed
wants to merge 1 commit into from

Conversation

LSChyi
Copy link
Contributor

@LSChyi LSChyi commented Sep 28, 2020

Dynamically skip acquiring the other half matrix if there are transport errors.

Description

The transport split hand causes the keyboard to become very laggy when the other half is not connected, down, or not yet ready. This is extremely serious when using the SPLIT_USB_DETECT, which is the default setting for Chibios, the other half hangs in the state until the SPLIT_USB_TIMEOUT. The default SPLIT_USB_TIMEOUT blocks the other hand and only starts working after 2 seconds, the main half is very laggy in the meanwhile and makes people think the keyboard is not working due to it tries to transport with the other half and times out all the time.

As a result, adding a mechanism to not acquiring the other half matrix based on the transport failure times could prevent the laggy behavior and still makes the main half working.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

common_features.mk Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Dec 17, 2020

Looks like you have some merge conflicts here, and looks like it needs to be rebased.

@LSChyi LSChyi force-pushed the transport_with_skip branch from 9449e06 to 6f4fe34 Compare January 15, 2021 06:53
@LSChyi LSChyi requested a review from drashna January 15, 2021 07:03
@LSChyi
Copy link
Contributor Author

LSChyi commented Jan 15, 2021

Rebased - please have a look

@drashna
Copy link
Member

drashna commented Feb 4, 2021

Sorry, looks like there is a merge conflict here.

@tzarc tzarc closed this Feb 27, 2021
@tzarc tzarc deleted the branch qmk:develop February 27, 2021 20:27
@tzarc
Copy link
Member

tzarc commented Feb 27, 2021

Sorry about that, GitHub decided to delete the develop branch from upstream when we merged it, despite being told otherwise. Reopened.

@tzarc tzarc reopened this Feb 27, 2021
@stale
Copy link

stale bot commented Apr 18, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale
Copy link

stale bot commented Jun 2, 2021

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.

@stale stale bot closed this Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants