-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip transport for another matrix based on error count #10468
Conversation
Looks like you have some merge conflicts here, and looks like it needs to be rebased. |
9449e06
to
6f4fe34
Compare
Rebased - please have a look |
Sorry, looks like there is a merge conflict here. |
Sorry about that, GitHub decided to delete the |
Thank you for your contribution! |
Thank you for your contribution! |
Dynamically skip acquiring the other half matrix if there are transport errors.
Description
The transport split hand causes the keyboard to become very laggy when the other half is not connected, down, or not yet ready. This is extremely serious when using the
SPLIT_USB_DETECT
, which is the default setting for Chibios, the other half hangs in the state until theSPLIT_USB_TIMEOUT
. The defaultSPLIT_USB_TIMEOUT
blocks the other hand and only starts working after 2 seconds, the main half is very laggy in the meanwhile and makes people think the keyboard is not working due to it tries to transport with the other half and times out all the time.As a result, adding a mechanism to not acquiring the other half matrix based on the transport failure times could prevent the laggy behavior and still makes the main half working.
Types of Changes
Issues Fixed or Closed by This PR
Checklist