Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build option firmware size impacts from rules.mk #5488

Closed
fauxpark opened this issue Mar 26, 2019 · 4 comments · Fixed by #6947
Closed

Remove build option firmware size impacts from rules.mk #5488

fauxpark opened this issue Mar 26, 2019 · 4 comments · Fixed by #6947

Comments

@fauxpark
Copy link
Member

fauxpark commented Mar 26, 2019

For example:

...
BOOTMAGIC_ENABLE = no    # Virtual DIP switch configuration(+1000)
MOUSEKEY_ENABLE = yes    # Mouse keys(+4700)
EXTRAKEY_ENABLE = yes    # Audio control and System control(+450)
...

These numbers are misleading, because they are outdated and as @drashna mentioned here: #5485 (comment), dependent on the compiler version. It seems there is not much point having them around since they will simply never be accurate.

But... these are in every rules.mk, so I won't bother making a PR for this, even though I strongly feel these kinds of changes should be done sooner rather than later as QMK grows in popularity, complexity and size.

@drashna
Copy link
Member

drashna commented Mar 28, 2019

@jackhumbert @skullydazed

Personally, I'm in favor of this. They're not accurate, and I don't think we should keep them in the repo.

@noroadsleft
Copy link
Member

Strongly in favor.

@roguepullrequest
Copy link
Contributor

Would this z

@fauxpark
Copy link
Member Author

Would this z

Probably not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants