Remove build option firmware size impacts

[amberstarlight]

Description

Removes references to build option sizes in each keyboard's rules.mk (e.g. (+1000)).

Includes the script used to do this in util/, rules_cleanup.sh.

I have also removed references to these sizes in the documentation, where appropriate.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Fixes #5488 - as @fauxpark comments;

These numbers are misleading, because they are outdated and as @drashna mentioned here: #5485 (comment), dependent on the compiler version. It seems there is not much point having them around since they will simply never be accurate.

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[fauxpark]

Nice work!

It's going to be way easier to review this if you split it up into manageable chunks, eg. alphabetically. Additionally, the modification of non-default keymaps will make it a breaking change, so you may want to either exclude the keymaps/ directories from the script, or manually filter out anything that isn't default-ish.

[amberstarlight]

@fauxpark thanks!

I've fixed the regex in the script (thanks for spotting @zvecr) and excluded the keymaps/ directories from it. Happy to split this into multiple PRs, as you did to remove boilerplate (e.g. #6804).

My thinking is to create 4 branches at this stage for keyboard directories;

• A-F (including 0-9, which is only 9 keyboard directories)
• G-L
• M-R
• S-Z

Does this sound good?

[noroadsleft]

More branches and smaller chunks might be easier to review. G through L I expect would be particularly large due to all the handwired boards and the KBDfans and Keebio vendor folders.

[fauxpark]

Yeah I think 0-9, then each letter individually, though some letters will have only a handful of boards so you can potentially combine them in places. This is what I'm going to do with the boilerplate stuff.

[drashna]

Actually, we've been trying to move to a python based CLI system, and ideally, this should be added to the qmk cli code, if possible.

https://docs.qmk.fm/#/cli_development

If you don't think you can do that, that's fine, no worries. But if you're able to, awesome!

[amberstarlight]

I'm not au fait with Python, so I'd have to take a look at this in the future after some learning.

[drashna]

Thanks!