Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation issue with Auto Shift? #1965

Closed
kshmelkov opened this issue Nov 4, 2017 · 1 comment · Fixed by #1966
Closed

Documentation issue with Auto Shift? #1965

kshmelkov opened this issue Nov 4, 2017 · 1 comment · Fixed by #1966

Comments

@kshmelkov
Copy link

Hello,

Recently I have tried to setup Auto Shift and even though I followed docs it didn't work. After some time I discovered that the correct line for rules.mk is

AUTO_SHIFT_ENABLE = yes

while the documentation suggests uppercase YES which didn't work for me. Surprisingly it didn't complain during compilation about this (should it?) I suppose it is a documentation typo?
@jcowgar
Copy link
Contributor

jcowgar commented Nov 4, 2017 •
edited
Loading

That is correct, it is a document typo. Sorry about that. I'll make the doc change and submit a pull request.

@jcowgar jcowgar mentioned this issue Nov 4, 2017
Merged
jackhumbert pushed a commit that referenced this issue Nov 6, 2017
@jcowgar @jackhumbert
Correct the rules.mk documentation for auto shift.
245b337 
fixes #1965
kgwong pushed a commit to kgwong/qmk_firmware that referenced this issue Nov 26, 2017
@jcowgar @kgwong
Correct the rules.mk documentation for auto shift.
ea67919 
fixes qmk#1965
LovesTha pushed a commit to LovesTha/qmk_firmware that referenced this issue Jul 24, 2018
@jcowgar
Correct the rules.mk documentation for auto shift.
f9afa00 
fixes qmk#1965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct the rules.mk documentation for auto shift.
2 participants
@jcowgar @kshmelkov