Skip to content

Commit

Permalink
Remove matrix_col_t to allow MATRIX_ROWS > 32 (#10183)
Browse files Browse the repository at this point in the history
The matrix_col_t type was added in commit 0284431 (part of #3449),
but then the code which used that type was removed in #6140, and no
other users were added since that time.  The presence of that type,
however, limits MATRIX_ROWS to 32, which probably does not matter for a
real keyboard, but prevents doing things like making a firmware to test
all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
  • Loading branch information
sigprof authored and noroadsleft committed Oct 30, 2020
1 parent 47fff74 commit 53ad78b
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions tmk_core/common/matrix.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,6 @@ typedef uint32_t matrix_row_t;
# error "MATRIX_COLS: invalid value"
#endif

#if (MATRIX_ROWS <= 8)
typedef uint8_t matrix_col_t;
#elif (MATRIX_ROWS <= 16)
typedef uint16_t matrix_col_t;
#elif (MATRIX_ROWS <= 32)
typedef uint32_t matrix_col_t;
#else
# error "MATRIX_ROWS: invalid value"
#endif

#define MATRIX_ROW_SHIFTER ((matrix_row_t)1)

#define MATRIX_IS_ON(row, col) (matrix_get_row(row) && (1 << col))
Expand Down

0 comments on commit 53ad78b

Please sign in to comment.