fix(listbox): prop to disable confirming selections on blur events #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haxxmaxx
changed the title
veinfors
reviewed
Jun 27, 2022
| @@ -59,6 +59,7 @@ export default function ListBoxInline({ app, fieldIdentifier, stateName = '$', o | |||
| sortByState = 1, | |||
| scrollState = undefined, | |||
| setCount = undefined, | |||
| shouldConfirmOnBlur = undefined, | |||
There was a problem hiding this comment.
Maybe it's just my personal preference, but I think it feels nicer calling it just confirmOnBlur.
There was a problem hiding this comment.
sure I can change
There was a problem hiding this comment.
or actually I just merged the other PR so easier to stick with this
There was a problem hiding this comment.
that's fine, just a detail
veinfors
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Temporary fix to disable confirming selections on blur events. This should eventually be refactored, see issue #863
Requirements checklist
yarn specOR
When build and tests have passed: