Bugfix: pending waiter #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atluq
approved these changes
Aug 28, 2024
| @@ -20,7 +20,7 @@ type ( | |||
| ) | |||
|
|
|||
| // NewHandler new instance of PendingHandler | |||
| func NewHandler(size int) Handler { | |||
| func NewHandler() Handler { | |||
Comment on lines
+408
to
+410
| func TestPendingWaiter(t *testing.T) { | ||
| counters := &statistics.ExecutionCounters{} | ||
| state := New(context.Background(), "", 120, nil, 1, 1, "", false, counters) |
There was a problem hiding this comment.
Did this simple test break the old one? If so, good! If not it would be a good idea to create such a test.
There was a problem hiding this comment.
yes I created it as a failing test with old one, and doesn't fail with new implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Squash commit message
Fixes bug where something added to state.pending after emptying, but before emptying of resthandler.pending would not wait as expected.
Info
Optional informative text (not to be included in commit message) relevant to reviewers.