Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix artifactmap using GUID from list or file #454

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

DnlLrssn
Copy link
Member

@DnlLrssn DnlLrssn commented Feb 9, 2024

Checklist

Squash commit message

  • Add Lookup in artifactmap also for guid from list and guid from file
  • Add test build for Go 1.22

Info

Optional informative text (not to be included in commit message) relevant to reviewers.

@DnlLrssn DnlLrssn requested a review from atluq February 9, 2024 10:50
Copy link
Contributor

@atluq atluq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to always return a real existing entry and not mix with fake entries, but I isn't that one point of the GUID app selection to not need to run an action to populate the artifact map before running e.g. openapp?

@DnlLrssn
Copy link
Member Author

DnlLrssn commented Feb 9, 2024

It makes sense to always return a real existing entry and not mix with fake entries, but I isn't that one point of the GUID app selection to not need to run an action to populate the artifact map before running e.g. openapp?

openapp would still work that way, other actions requiring data from the artifact map returns an error if it's not a "real" one when using GUID's. And yes the "fake" entry is to allow for some misuse of the tool, but we shouldn't force other actions to fail to support a misuse scenario.

Copy link
Contributor

@atluq atluq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that there was an artificial mapEntry returned from LookupAppGUID. Question answered. Looks good!

@DnlLrssn DnlLrssn merged commit 15678e4 into master Feb 9, 2024
4 checks passed
@DnlLrssn DnlLrssn deleted the bugfix/artifactmap branch February 9, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants