Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing types to event struct #452

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Add missing types to event struct #452

merged 2 commits into from
Feb 7, 2024

Conversation

DnlLrssn
Copy link
Member

@DnlLrssn DnlLrssn commented Feb 6, 2024

Checklist

Squash commit message

Add missing types to event struct

Info

Optional informative text (not to be included in commit message) relevant to reviewers.

@DnlLrssn DnlLrssn requested a review from atluq February 6, 2024 15:03
ResourceID string `json:"resourceId,omitempty"`
ResourceType string `json:"resourceType,omitempty"`
ResourceSubType string `json:"resourceSubType,omitempty"`
ResourceSubSubType string `json:"resourceSubSubType,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know this existed 😆

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SubSubType I mean

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me neither until now

@DnlLrssn DnlLrssn merged commit baee0cb into master Feb 7, 2024
3 checks passed
@DnlLrssn DnlLrssn deleted the update/events-struct branch February 7, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants