Update action code snippets for vscode. (#495)

* add tabbable package + add displayname to paramter example * fix linting issues due to new linter version
qlik-oss · Aug 27, 2024 · acc4dcf · acc4dcf
1 parent 2670cc9
commit acc4dcf
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/docs/vscode/gopherciser.code-snippets b/docs/vscode/gopherciser.code-snippets
@@ -4,7 +4,7 @@
 		"prefix": "action",
 		"description": "Adds scenario action skeleton, to be used in an empty file. Action needs to be registered after completion.",
 		"body": [
-			"package scenario",
+			"package ${3:scenario}",
 			"",
 			"import (",
 			"\t\"github.com/qlik-oss/gopherciser/action\"",
@@ -15,7 +15,7 @@
 			"type (",
 			"\t// ${1:${TM_FILENAME_BASE/(.*)/${1:/pascalcase}/}}Settings ${1:${TM_FILENAME_BASE/(.*)/${1:/pascalcase}/}} ${2:describe action here}",
 			"\t${1:${TM_FILENAME_BASE/(.*)/${1:/pascalcase}/}}Settings struct {",
-			"\t\tParameter string `json:\"parameter\" doc-key:\"path.to.description\"`",
+			"\t\tParameter string `json:\"parameter\" displayname:\"Parameter\" doc-key:\"path.to.description\"`",
 			"\t}",
 			")",
 			"",
@@ -77,4 +77,4 @@
 			"//}",			
 		]
 	}
-}
+}
diff --git a/helpers/errors_test.go b/helpers/errors_test.go
@@ -5,6 +5,7 @@ import (
 	"testing"
 
 	"github.com/hashicorp/go-multierror"
+	"github.com/pkg/errors"
 )
 
 func TestFlatten(t *testing.T) {
@@ -15,15 +16,15 @@ func TestFlatten(t *testing.T) {
 	}
 
 	firstError := "first error"
-	mErr = multierror.Append(mErr, fmt.Errorf(firstError))
+	mErr = multierror.Append(mErr, errors.New(firstError))
 
 	err := FlattenMultiError(mErr)
 	if err == nil || err.Error() != firstError {
 		t.Errorf("Expected<%s> got: %v", firstError, err)
 	}
 
 	secondError := "second error"
-	mErr = multierror.Append(mErr, fmt.Errorf(secondError))
+	mErr = multierror.Append(mErr, errors.New(secondError))
 	err = FlattenMultiError(mErr)
 	expected := fmt.Sprintf("2 errors occurred:\n\t* %s\n\t* %s\n\n", firstError, secondError)
 	if err == nil || err.Error() != expected {

diff --git a/scenario/select.go b/scenario/select.go
@@ -663,7 +663,7 @@ func recursiveDataFromStackedPivotCell(cell *enigma.NxStackedPivotCell, currentD
 		return
 	}
 
-	if cell.SubNodes != nil && len(cell.SubNodes) > 1 {
+	if len(cell.SubNodes) > 1 {
 		for _, subCell := range cell.SubNodes {
 			recursiveDataFromStackedPivotCell(subCell, currentDim+1, getDim, possibleMap)
 		}

diff --git a/statistics/samplecollector_test.go b/statistics/samplecollector_test.go
@@ -12,21 +12,21 @@ func TestSampleCollector_Average(t *testing.T) {
 		t.Parallel()
 		collector := generateSamples(50)
 		if err := validateAverage(collector); err != nil {
-			t.Errorf(err.Error())
+			t.Error(err.Error())
 		}
 	})
 	t.Run("medium sample set", func(t *testing.T) {
 		t.Parallel()
 		collector := generateSamples(500)
 		if err := validateAverage(collector); err != nil {
-			t.Errorf(err.Error())
+			t.Error(err.Error())
 		}
 	})
 	t.Run("large sample set", func(t *testing.T) {
 		t.Parallel()
 		collector := generateSamples(10000000)
 		if err := validateAverage(collector); err != nil {
-			t.Errorf(err.Error())
+			t.Error(err.Error())
 		}
 	})
 }