Skip to content

Commit

Permalink
Merge pull request #351 from qld-gov-au/dependabot/npm_and_yarn/devel…
Browse files Browse the repository at this point in the history
…op/eslint-plugin-mdx-3.1.1

Bump eslint-plugin-mdx from 3.0.0 to 3.1.1
  • Loading branch information
ThrawnCA authored Dec 27, 2023
2 parents 83f39a8 + de45969 commit b1f8162
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 13 deletions.
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"eslint-plugin-jest": "^27.6.0",
"eslint-plugin-json": "^3.1.0",
"eslint-plugin-jsx-a11y": "^6.8.0",
"eslint-plugin-mdx": "^3.0.0",
"eslint-plugin-mdx": "^3.1.1",
"eslint-plugin-prettier": "^5.1.1",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.3.0",
Expand Down
9 changes: 5 additions & 4 deletions src/stories/WhyAndWhen.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,10 @@ We will use **Grab my IP** solution as an example.
- If you want to save the solution as a resource component, you better do it as a custom component instead.
- The custom JS in your solution is too complex, bulky, prone to error and needed to be tested properly.
- You need to manipulate an out of the box component in a way that it defeated its own purpose.
- A solution is too complex to be reproduced in another form/project by another consumer.A solution can't be achived with out of the box components.
- A solution is too complex to be reproduced in another form/project by another consumer.
- A solution can't be achieved with out of the box components.

<h3>Don't develop solution in custom component library when:</h3>
<h3>Don&apos;t develop solution in custom component library when:</h3>

- A solution only used in a particular form.
- A solution can be achieved by modifiying out of the box properties, doesn't invove custom JS or only involve simple custom JS.
- A solution is only used in a particular form.
- A solution can be achieved by modifying out of the box properties, doesn't involve custom JS or only involves simple custom JS.

0 comments on commit b1f8162

Please sign in to comment.