Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API to allow QubitMapper where QubitConverter is used. #999
Update API to allow QubitMapper where QubitConverter is used. #999
Changes from 5 commits
643cb61
1402cc4
b8f7d7f
7e2e585
0480c2c
925e821
75d856c
149d3da
ad0ef6f
a8f0758
f86726b
265b83c
8e9f7b5
049e372
83913fc
4a16031
15dd0e1
ab261b3
968d556
b5ff687
7baf401
1822ef7
cb81678
3552929
17f9954
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future I would like to rename this argument to
qubit_mapper
. This will not be an easy process so it will be done in a separate PR once all the API is updated to supportQubitMapper
and works. I'm mentioning it now just as an FYI.This will not be an easy undertaking but I will start discussing some plans on how to do this properly offline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to do a thorough pass of the docs. Just mentioning this so its on our radar (I know that this is still a draft PR)