Changed to install qiskit not qiskit-terra #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now working better - but failing since stable released Nature is not compatible with Qiskit 1.0 in terms of using the qiskit.tools parallel_map function which was moved etc |
woodsp-ibm
added
the
stable backport potential
mrossinek
reviewed
Feb 20, 2024
|
I updated things as they were and changed qiskit-terra to qiskit. As the requirements do not call out qiskit explictly that could be possible what you say, but it still has all that stuff in there that allows it to be run off of main branches for either, not only stable. Could one simplify the CI here further - I imagine, I just updated what was there. |
Pull Request Test Coverage Report for Build 7937030412Details
💛 - Coveralls |
mrossinek
approved these changes
Feb 23, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit f9a6909)
mrossinek
pushed a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit f9a6909) Co-authored-by: Steve Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems the CI actions and workflows had not been updated and still referred to and installed qiskit-terra. That is no longer part of Qiskit 1.0 and so it installed a pre-1.0 version where qiskit-terra was still there. Later it ended up installing Qiskit 1.0 and with both in the same environment things failed.
I changed the actions to no longer refer to anything as Terra and install Qiskit only.
Details and comments
Probably want to backport this to keep the stable branch running too.