Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sphinx theme #44

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

arnaucasau
Copy link
Contributor

@arnaucasau arnaucasau commented Sep 25, 2023

Summary

Updates to new Ecosystem theme.

For more information: Qiskit/qiskit_sphinx_theme#232

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6301640619

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.632%

Totals Coverage Status
Change from base Build 6122556618: 0.0%
Covered Lines: 118
Relevant Lines: 152

💛 - Coveralls

@mrossinek
Copy link
Member

How does this relate to #40?

@frankharkins
Copy link

@mrossinek: This project is being taken over by @arnaucasau, I'll close the other PR

Copy link

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested locally and it works well for me. Thanks @arnaucasau!

@mrossinek
Copy link
Member

Since this takes over from #40 but that was still a draft, should this also be considered a draft or is this actually good to go? I do not know if you have any timeline in mind/want to sync this with some other documentation aspects or if this is decoupled and can be merged any time.

@frankharkins
Copy link

Sorry for the poor communication. Yes this PR is ready to be reviewed and can be merged at any time.

Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Docs will be republished with the next release (once #43 gets unblocked and subsequently merged).

@mrossinek mrossinek merged commit 7ccd80e into qiskit-community:main Sep 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants