This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Update 'auto' method to not use SCS solver for CVXPY #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
added
Changelog: Bugfix
mtreinish
approved these changes
Nov 11, 2020
mtreinish
pushed a commit
to mtreinish/qiskit-ignis
that referenced
this pull request
Nov 12, 2020
…y#536) Fix the "auto" method of the tomography fitters to only use "cvx" if CVXPY is installed and a third-party SDP solver other than SCS is available. This is because the SCS solver has lower accuracy than other solver methods and often returns a density matrix or Choi-matrix that is not completely-positive and fails validation when used state_fidelity or process_fidelity functions (cherry picked from commit 006876e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
"auto"method of the tomography fitters to only use"cvx"if CVXPY is installed and a third-party SDP solver other than SCS is available.This is because the SCS solver has lower accuracy than other solver methods and often returns a density matrix or Choi-matrix that is not completely-positive and fails validation when used state_fidelity or process_fidelity functions
Details and comments