This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Added pulse calibrations #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to add tests |
taalexander
suggested changes
Nov 6, 2019
There was a problem hiding this comment.
This is very cool @dcmckayibm.
My biggest concern is an Ignis wide issue, in that Fitters are for multiple qubits but are essentially embarrassingly parallel. Having multiple qubits in a fitter is fine for things like 2 qubit gates, but having both parallel and multi-qubit calibrations together in the same class are confusing and complicate the code. If we can make things per-qubit, we can simplify things a lot.
ajavadia
reviewed
Nov 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments