Fix bug in tomography conditionals on multiple cregs #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates tomography circuit generation to work around issues in QuantumCircuit.compose for circuits with conditional instructions on multiple registers.
chriseclectic
added
backport stable potential
ihincks
reviewed
Nov 7, 2022
ihincks
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #943
Fixes bug in
StateTomographyandProcessTomographyexperiments where if the input circuit contained conditional instructions with multiple classical registers the tomography measurement circuits would contain incorrect conditionals due to a bug in theQuantumCircuit.composemethod.Details and comments
This fixes the issue by creating a tomography template circuit containing the same registers as the input circuit with an additional classical register added for tomography measurements, rather than creating a template with a single flat classical register of the required total number of classical bits.