-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CR Hamiltonian experiment without cr_gate #794
CR Hamiltonian experiment without cr_gate #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I wonder if the different cases (with and without backend/gate) should be tested more systematically.
Thanks Will, actually I found another bug with extra test 12faf53
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I wonder though if you should more systematically have four tests, with/without backend and with/without cr_gate that all make sure circuits works without error. I guess you cover all cases except no backend with cr_gate currently.
Thanks,
This is tested in |
* Bug fix; instantiate CR Ham expr without cr_gate * fix another bug with extra unittest
* Bug fix; instantiate CR Ham expr without cr_gate * fix another bug with extra unittest
* Bug fix; instantiate CR Ham expr without cr_gate * fix another bug with extra unittest
Summary
Bug fix for
CrossResonanceHamiltonian
experiment instantiation without cr gate.Details and comments
self._cr_gate
should be assigned before calling super init method since it calls set backend where we check the cr gate.https://qiskit.slack.com/archives/C02CFNAKURE/p1651458517025279