Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in EPG computation for devices with ECR gates #1431

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

itoko
Copy link
Contributor

@itoko itoko commented Mar 27, 2024

Summary

Fixed a bug in EPG (error per gate) computation in RBAnalysis where it fails with a TypeError for backends with ECR gate as a 2-qubit basis gate (e.g. IBM Eagle processors).
Fixed #1419 .

Details and comments

Added the standard gate error ratio (1.0) for ECR gate as suggested in the issue. Also added a sentence to explain how to skip EPG computation in the manual.

@itoko itoko added backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Mar 27, 2024
@itoko itoko requested review from nkanazawa1989 and removed request for nkanazawa1989 March 27, 2024 06:02
@itoko itoko requested a review from nkanazawa1989 April 9, 2024 05:46
@coruscating coruscating added this to the Release 0.7 milestone Apr 10, 2024
Copy link
Collaborator

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkanazawa1989 nkanazawa1989 added this pull request to the merge queue Apr 16, 2024
Merged via the queue into qiskit-community:main with commit 44178f7 Apr 16, 2024
11 checks passed
mergify bot pushed a commit that referenced this pull request Apr 16, 2024
### Summary
Fixed a bug in EPG (error per gate) computation in `RBAnalysis` where it
fails with a ``TypeError`` for backends with ECR gate as a 2-qubit basis
gate (e.g. IBM Eagle processors).
Fixed #1419 .

### Details and comments
Added the standard gate error ratio (`1.0`) for ECR gate as suggested in
the issue. Also added a sentence to explain how to skip EPG computation
in the manual.

(cherry picked from commit 44178f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
3 participants