Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch GitHub runner from macOS-latest to macOS-14 #1421

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

wshanks
Copy link
Collaborator

@wshanks wshanks commented Mar 12, 2024

macOS-14 uses Apple Silicon (M1) instead of Intel x86.

@wshanks
Copy link
Collaborator Author

wshanks commented Mar 12, 2024

I noticed recently that GitHub has started providing M1 Mac runners:

https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/

They won't transition to being default for a few months. I was curious if the tests would run okay. We could just wait for the default to change rather than merging this.

@wshanks
Copy link
Collaborator Author

wshanks commented Mar 12, 2024

Okay, hmm, interesting. The Apple Silicon image only provides Python 3.10+, it seems. I wonder if 3.8 and 3.9 could get builds before it becomes the default image? If we can't find a definite answer, we might wait and see. If they won't, then we can act now or wait but we have to do something when the default changes. One option is pinning to the older image. Another option is installing Python a different way for 3.8 (conda-forge has osx-arm64 builds for Python 3.8 for example). A motivation for not pinning to the old image is that M1 runners might be faster. For example, the 3.12 run here took about 5 minutes, similar to the Linux runs. In the Actions history, the Mac runs seem to take 7-12 minutes. Keep in mind this is one M1 sample and just a handful of older samples I checked, so it might not be representative, but it has seemed like the Mac run times have varied wildly in the past while the Linux ones have been more consistent.

@wshanks
Copy link
Collaborator Author

wshanks commented Mar 12, 2024

From actions/setup-python#808, it looks like support for 3.8 and 3.9 is planned.

macOS-latest now uses Apple Silicon (M1) instead of Intel x86. GitHub
recently added a Python 3.8 build for Apple Silicon, so we can revert
067bf7e
@wshanks wshanks marked this pull request as ready for review April 25, 2024 23:58
@wshanks
Copy link
Collaborator Author

wshanks commented Apr 26, 2024

@coruscating An macOS Arm64 build for Python 3.8 was added to GitHub, so this should be good to go now. I don't know if the CI job (macos-13 vs macos-latest) confusion is a problem for merging?

Copy link
Collaborator

@coruscating coruscating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wshanks. CI isn't a problem—I changed the branch protection rules back to using macos-latest so we're good to go.

@coruscating
Copy link
Collaborator

@wshanks Oops, spoke too soon. cron-staging.yml should go back to latest as well.

@coruscating coruscating added this pull request to the merge queue Apr 26, 2024
Merged via the queue into qiskit-community:main with commit d2449a4 Apr 26, 2024
11 checks passed
@wshanks wshanks deleted the macos-14 branch April 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants